Whirlpool

I have made a script to send emails in PHP:

<?php
$to = "XXX@bigpond.com";
$subject = "request";

$body = $_GET["email"];
if (mail($to, $subject, $body)) {

echo("<br/><br/>Message successfully sent!</p>");

} else {

echo("<br/><br/>Message delivery failed...</p>");

}

?>

But when i load the page it says:

Message successfully sent!"); } else { echo("

Message delivery failed...
"); } ?>

where am i going wrong?

Check that your double-quotes are "real" double-quotes and not “curly” quotes or some other vaguely quote-like symbol.

Edit: That won't be the problem, but it might keep you occupied until we can think of something else.

I just had a go at it, and it works fine for me (copied and pasted). You could try what Foonly said, but imho that would be likely to throw up a syntax error rather than just spit out the rest of the script.

Maybe you just need to refresh or re-upload the file. Sometimes if I'm editing a file too quickly sometimes it doesn't work as expected.

already tryed reuploading. The host is x10hosting

echo() is not actually a function so it is safer not to use parentheses with it. Try

echo "<br/><br/>Message successfully sent!</p>";

Modulus writes...

echo() is not actually a function so it is safer not to use parentheses with it.

it works fine for me either way. I think the problem lies elsewhere in his setup/script

Modulus writes...

echo() is not actually a function so it is safer not to use parentheses with it.

And in this particular case, you could technically (although I wouldn't bother searching your code to change other instances) be run faster by using single quotes.

In double quotes, PHP will "waste time" checking the string for any variable names so it can echo their actual value.

So in theory,
echo '<br/><br/>Message successfully sent!</br></br>';
will run faster than
echo "'<br/><br/>Message successfully sent!</br></br>";

Sorry I couldn't help with your actual problem!
My only guess is that you haven't pasted your code, but re-typed for whirlpool.
Are you certain your code is not
t!</?>");
} else {
(that's a closing ?> which would then tell apache/iis to display the rest of the scripts code)

Is your file saved with a .php file extension? (genuine question, as I am not sure if you are a beginner or not)

robert writes...

(that's a closing ?> which would then tell apache/iis to display the rest of the scripts code)

lol then why does it display the text prior to ?>

try loading the page again, and go to View->View Source or View->Page Source (or whatever variation you have, depending on your browser) and tell us exactly what you get.

No, it is a .html
I have put php into html files befor and it has worked fine. This script worked on my lasthost but not on x10

edit: Sorry, i am so dumb....

ironheart writes...

lol then why does it display the text prior to ?>

Read my paragraph again – closely.
I'm asking if the closing tag is being incorrectly used instead of a closing < /p> ... php would display everything it's told to before the closing tag, then quit php, then the remaining code would be displayed to the browser because php has stopped interpreting code.

Now the OP has confirmed the filename is .html that was a really good guess of mine :)

OP, have you tried failing the message on purpose?

Thanks for the help, should have named it php....

A note on php mail:

Where you write: Message successfully sent! / Message delivery failed...

That's not entirely accurate. mail's return value is whether the message was sent to the underlying mail delivery system successfully or not, not whether the mail was actually sent to the email address.

You could run into the case where mail reports true that the message was accepted for delivery, but still fails to reach its destination.

robert writes...

I'm asking if the closing tag is being incorrectly used instead of a closing < /p>

doesn't appear to be in the code he pasted. If he can't copy and paste code into a window, he'll be struggling a lot. I gave him the benefit of the doubt. he also claims that the script worked before. your post was half about the usage of apostrophes vs double-quotes, which was not very helpful in his case. Sorry if i didn't bother reading properly when presented with a handful of unrelated material

CoastWeb writes...

You could run into the case where mail reports true that the message was accepted for delivery, but still fails to reach its destination.

Yep.

Returns TRUE if the mail was successfully accepted for delivery, FALSE otherwise.

It is important to note that just because the mail was accepted for delivery, it does NOT mean the mail will actually reach the intended destination.

Uhh I think you'd have to use that Receipt functionality to find out whether someone received the email or not, but that's not 100% either. I never click positively to that request, i always cancel it hehe

Or try using web bugs. :0

CoastWeb writes...

Or try using web bugs. :0

What, little transparent gifs? You can't track 'em if the recipient doesn't load images.